nicolas-georger/deepseek-kubernetes-sandbox
1
0
Fork 0
mirror of https://github.com/sredevopsorg/deepseek-kubernetes-sandbox.git synced 2026-11-03 01:13:24 +00:00
Code Projects Releases Activity

Dial the sandbox pod IP for WebSocket upgrades (#10)

Browse Source 
DSH's Host fence (isTrustedApiRequest) only trusts loopback, an allow-listed
host, or its own bind address, and requires any Origin to match the Host
authority. The gateway forwarded the browser Host as an additional header,
but websockets derives Host from the URI and cannot be overridden, so the
request carried a duplicate/mismatched Host plus the browser Origin and DSH
answered 403. The gateway then closed with 1011, which the DSH client retries
forever:

  [connection] connection lost, retry #1 ... #55

Dial the pod IP instead - it is the bind address, so the derived Host passes
the fence - and forward no Origin; CSWSH is already rejected by same_origin()
before the upstream connection. Fall back to the service FQDN when
status.podIPs is empty and bracket IPv6 literals.

Reproduced against dsh-v0.2.1-rc.2: pod-IP upgrade with no Origin opens;
the same upgrade carrying the browser Origin gets HTTP 403.

Co-authored-by: SREDevOpsAgents <agents@sredevops.org>
This commit is contained in:
SREDevOps.org Agent
2026-10-21 15:09:51 -03:00
committed by GitHub
parent 163abaeac0
commit abe5b4d5bb
3 changed files with 34 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
examples/dsh-agents-as-a-service/gateway/test_gateway.py
View File

@@ -38,6 +38,7 @@ from gateway import (
TOKEN = "s3cret-token"
POD_UID = "pod-uid-1"
POD_IP = "10.0.0.7"
FQDN = "dsh-alice-sbx.test-ns.svc.cluster.local"
@@ -206,6 +207,7 @@ def add_user(k8s, user="alice", token=TOKEN, ready=True, pod_name=None, suffix="
"status": {
"conditions": [{"type": "Ready", "status": "True"}] if ready else [],
"serviceFQDN": FQDN,
"podIPs": [POD_IP],
},
}
k8s.pods[pod_name] = {"metadata": {"name": pod_name, "uid": POD_UID}}
@@ -1202,13 +1204,16 @@ def test_ws_bridges_frames_and_injects_cookie(env):
assert ws.receive_text() == "pong"
url, kwargs = env.ws_connect.calls[0]
assert url.startswith(f"ws://{FQDN}:3080/api/remote.mux")
# DSH's Host fence: dial the pod IP (its bind address) and never forward
# the browser's Host/Origin, which would make the upgrade 403.
assert url.startswith(f"ws://{POD_IP}:3080/api/remote.mux")
assert "token=secret" not in url
assert "x=1" in url
headers = kwargs["additional_headers"]
assert "authorization" not in headers
assert headers["cookie"] == "dsh-auth-a=one"
assert headers["host"] == "testserver"
assert "host" not in headers
assert "origin" not in headers
assert env.ws_connect.instances[0].sent == ["hello"]
@@ -1228,7 +1233,7 @@ def test_ws_cookie_same_origin_bridges_frames(env):
headers = env.ws_connect.calls[0][1]["additional_headers"]
assert headers["cookie"] == "dsh-auth-a=one"
assert headers["origin"] == "http://testserver"
assert "origin" not in headers
def test_ws_handshake_failure_closes_1011(env):