* feat(repo)!: restructure around the dsh-harness image and one example per implementation
- the root Dockerfile is the primary artifact; versions.env is the single source of truth
- merge gateway-api/dsh-demo into examples/dsh-agents-as-a-service (manifests/, exposure variants)
- move the single-tenant template into examples/minimal-single-tenant
- publish the gateway as a nested package under the repository image
- mirror the DSH ref for release identities (first release dsh-v0.2.1-rc.2-r2)
- CI: lint/python/manifests/gateway-image, reusable multi-arch build, tag-driven release, weekly e2e
- docs: README, docs/{main-image,examples,gitflow,versioning}, example READMEs, AGENTS.md, governance
- SSO is opt-in again; gateway pull policy and cookie defaults match the documented demo
BREAKING CHANGE: example manifest paths, the gateway image name, and the removal
of deploy/ and gateway-api/ affect existing deployments; see the migration table
in README.md.
* docs(changelog): generate initial changelog from history
* fix(scripts): make set-version update Dockerfile and sample revision pins
* build(hadolint): document intentional lint exceptions for the main image
---------
Co-authored-by: SREDevOpsAgents <agents@sredevops.org>
17 KiB
Architecture
This document describes the browser-usable agents-as-a-service platform in this example (README, manifests, gateway): how the gateway, Kubernetes, and DSH Web fit together, and why the design looks the way it does.
Scope: one Kubernetes namespace (dsh-demo), one shared DSH Web image, one gateway deployment,
and one DSH Web pod + PVC per user. The cluster is assumed to run
agent-sandbox v1.0.7 with the extensions
(SandboxTemplate, SandboxWarmPool, SandboxClaim).
Container view
flowchart LR
browser["Browser"]
subgraph cluster["Kubernetes cluster - namespace dsh-demo"]
gw["Gateway Deployment<br/>Starlette ASGI on uvicorn :8080<br/>landing page + auth + proxy + sweeper"]
api["Kubernetes API Server"]
ctrl["agent-sandbox controller"]
pool["SandboxWarmPool dsh-pool<br/>2 pre-warmed spares"]
claim["SandboxClaim dsh-USER<br/>one per user"]
sb["Sandbox dsh-pool-xxxx<br/>spec.operatingMode"]
svc["Headless Service<br/>status.serviceFQDN"]
pod["DSH Web pod<br/>node process :3080"]
pvc[("PVC dsh-home-SANDBOX<br/>/home/node/.dsh")]
end
browser -->|"HTTP + WebSocket<br/>/u/USER/**"| gw
gw -->|"claims, sandboxes, pods, pod logs"| api
api --> ctrl
ctrl -->|"adopt / suspend / resume"| claim
claim --> sb
pool -.->|"replenishes"| sb
sb --> svc
svc --> pod
pod --> pvc
Responsibilities:
| Component | Responsibility |
|---|---|
| Browser | Holds only the gateway session cookie (dsh_gw_session). Talks exclusively to the gateway. |
| Gateway | Signup/login, session auth, SandboxClaim lifecycle, wake-on-connect, idle sweeper, HTTP/SSE/WebSocket reverse proxy, DSH launch-token handshake. |
| Kubernetes API | Source of truth for claims, sandboxes, and pods; also the log source for the DSH launch token. |
| agent-sandbox controller | Adopts warm spares on claim, flips operatingMode (Running/Suspended), garbage-collects sandbox + PVC on claim delete. |
| DSH Web pod | One dsh web process per user, state on the per-user PVC, listening on 3080. |
| Warm pool | Keeps N Ready sandboxes so signup is a label flip instead of a cold start. |
Exposure variants
The base manifests deploy the gateway as a ClusterIP Service (dsh-gateway:8080) and expose
nothing outside the cluster. Two mutually exclusive variants live under
manifests/exposure/:
| Variant | Entry point | Authentication | Notes |
|---|---|---|---|
| Ingress | Traefik Ingress + optional TLS |
the gateway's own signup/session cookie | simplest; no external IdP; set COOKIE_SECURE=true with HTTPS |
| Gateway API + SSO | Gateway API Gateway/HTTPRoute terminating TLS |
GitHub OAuth via oauth2-proxy, identity forwarded as X-Forwarded-User |
requires AUTH_PROXY_HEADER on the gateway; the trust boundary applies |
They are alternatives, not a stack: applying both creates a second path to the same gateway
and defeats SSO. When SSO is enabled, the Service must stay ClusterIP and be reachable only
through oauth2-proxy — otherwise any client can send X-Forwarded-User itself and be treated
as that user. The gateway ignores the header unless AUTH_PROXY_HEADER is set. See the
exposure README and the
gateway README.
Flows
Signup (browser)
sequenceDiagram
autonumber
actor B as Browser
participant G as Gateway
participant K as Kubernetes API
participant C as agent-sandbox controller
B->>G: POST /users (form: user=bob, Origin)
G->>G: validate user name and body size
G->>K: create SandboxClaim dsh-bob (warmPoolRef)
K->>C: reconcile claim
C-->>K: adopt spare, Ready, status.sandbox.name = dsh-pool-xxxx
G->>K: read claim (status) + sandbox + pod
G-->>B: 303 Location /u/bob/ + Set-Cookie dsh_gw_session
Note over G: JSON clients instead get 201 (Ready),<br/>202 (accepted, still waking), or 409 (conflict)
Form signup waits up to WAKE_TIMEOUT for the claim to become Ready, then redirects; the
first proxied request also waits for Ready and performs the DSH handshake (below). A 409
means the user already has a claim, in which case POST /login (bearer token) or the existing
cookie is the right path.
First request / proxy (with handshake)
sequenceDiagram
autonumber
actor B as Browser
participant G as Gateway
participant K as Kubernetes API
participant D as DSH Web pod
B->>G: GET /u/bob/ (Cookie dsh_gw_session)
G->>G: authenticate cookie, user = bob
G->>K: resolve claim -> sandbox -> pod
alt sandbox Suspended
G->>K: patch operatingMode=Running (wake)
loop until Ready or WAKE_TIMEOUT
G->>K: read sandbox Ready condition
end
end
G->>K: read pod logs (tail)
K-->>G: "dsh web: ...?token=..." line
G->>D: GET /?token=... (browser Host, X-Forwarded-*)
D-->>G: 303 + Set-Cookie dsh-auth-*
G->>G: cache cookie for (user, pod UID, Host)
G->>G: strip Cookie/Authorization/hop-by-hop headers
G->>D: replay request with dsh-auth cookie
D-->>G: 200 HTML / SSE stream
G-->>B: 200 (upstream Set-Cookie dropped, Location rewritten)
Handshake cache behavior: one entry per (user, pod UID, Host); refreshed once when DSH answers
401; dropped when the sandbox is suspended or deleted. The launch token and the DSH auth
cookie never reach the browser.
Wake-on-connect and idle suspend
sequenceDiagram
autonumber
participant S as Sweeper - lifespan task
participant G as Gateway
participant K as Kubernetes API
actor B as Browser
S->>G: no proxied request for IDLE_TIMEOUT
G->>K: patch sandbox operatingMode=Suspended
K-->>G: pod deleted, PVC + Service retained
Note over S,G: in-flight requests/WebSockets are tracked,<br/>so a busy turn is never suspended
B->>G: GET /u/bob/ after a while
G->>K: patch operatingMode=Running
G->>K: wait for Ready (WAKE_TIMEOUT)
G-->>B: request held, then served
Suspend deletes only the pod. The PVC keeps conversations, sessions, and config, so resume reattaches exactly the same state.
Ownership boundary. The gateway shares its namespace with claims created outside it — the
example's resource-layer walkthrough applies dsh-alice by hand, and every claim is named
dsh-<user>. Claims the gateway creates carry aaas.example.com/managed-by=dsh-gateway; the
sweeper skips everything else, so it can never suspend a sandbox an operator is using. Without
that marker the sweeper would suspend a hand-applied claim 60s after first sighting and break
kubectl logs/port-forward against its pod.
Resume and file ownership. The pod template sets fsGroupChangePolicy: OnRootMismatch on
purpose. DSH's credentials plugin refuses to boot when .credentials.yaml has any group/other
permission bit (it creates the file 0600). The kubelet's default fsGroup policy (Always)
recursively ORs 0660 into every file on each pod start, so the first resume of a sandbox would
crash-loop with mode 660. OnRootMismatch only rewrites ownership/permissions when the volume
root does not already match the fsGroup, which it does after the first mount — so suspend/resume
keeps working. Sandboxes snapshot their pod template, so an updated SandboxTemplate does not
retroactively change existing ones.
WebSocket
sequenceDiagram
autonumber
actor B as Browser
participant G as Gateway
participant D as DSH Web pod
B->>G: GET /u/bob/... Upgrade: websocket (Cookie dsh_gw_session)
G->>G: authenticate + mark user in-flight
alt cookie missing/invalid
G-->>B: 101 upgrade, then close 4401
else authenticated
G->>D: websockets.connect(path, Host, Cookie dsh-auth)
alt upstream handshake fails
G-->>B: 101 upgrade, then close 1011
else bridged
G-->>B: 101 Switching Protocols
loop frames
B->>D: frames proxied through G
D->>B: frames proxied through G
end
G->>G: clear in-flight on close
end
end
Decisions and trade-offs
ADR-1: Starlette ASGI instead of a sync Flask proxy
- Decision: implement the gateway as a Starlette app served by
uvicorn gateway:create_app --factory. - Why: the browser needs WebSocket upgrades, streaming SSE responses, and concurrent long-poll wake requests. A requests-based Flask proxy cannot upgrade connections and blocks workers while a sandbox wakes.
- Cost: async code paths and explicit bridging for the sync
kubernetesclient (offloaded to threads). Accepted: one small service, one framework.
ADR-2: Path-based routing (/u/{user}/) instead of per-user subdomains
- Decision: serve each user under
https://gateway/u/{user}/. - Why: one hostname, one TLS certificate, no wildcard DNS or per-user Ingress objects. DSH
uses relative asset/API URLs and injects
<base href="./">, so a path prefix works; the gateway rewrites absolute-pathLocationheaders and redirects/u/{user}to/u/{user}/. - Cost: any upstream code that emits root-absolute URLs would need rewriting; cookie
domains are shared (mitigated by stripping DSH
Set-Cookie). If DSH ever changes its base handling, per-user subdomains are the fallback.
ADR-3: Server-side launch-token handshake instead of exposing the token
- Decision: the gateway reads DSH's launch token from pod logs, performs the token
handshake itself, caches DSH's auth cookie, and authenticates the browser with its own
HttpOnlycookie. - Why: DSH has no token API and returns
401on/without the launch-token cookie. Handing the token to the browser would put it in URLs, history, and logs, and would let users bypass gateway auth. - Cost: log reading permission and a brittle parser; see Upstream feature request. This is the least durable part of the design and the first thing to replace.
ADR-4: In-memory state, single replica
- Decision: idle clocks, handshake cache, and in-flight tracking live in gateway memory; the Deployment runs one replica.
- Why: the simplest thing that works, with no extra datastore for a demo/reference platform.
- Cost: a restart forgets idle timers (sandboxes stay Running until their next request) and the handshake cache; two replicas would double-suspend and race. Scaling out requires moving this state to a shared store (Redis/Postgres) or leader election. Documented instead of hidden.
ADR-5: Claims as the user record
- Decision: a user is a
SandboxClaimnameddsh-<user>; the bearer-token SHA-256 lives in a claim annotation, and the gateway marks its own claims withaaas.example.com/managed-by=dsh-gateway. - Why: no database, no separate account service; deleting the claim is account deletion and cascades everything. The ownership annotation keeps a namespaced claim list safe to share with objects created by hand or by other controllers.
- Cost: no password reset, no admin API, no audit log of its own; Kubernetes API load grows
with users. Claims created before the ownership marker existed must be annotated
(
kubectl annotate sandboxclaim ...) to keep being swept. Fine for a reference pattern, not for a product.
ADR-6: Gateway cookie session instead of bearer tokens in the browser
- Decision: browsers get
dsh_gw_session=<user>:<token>,HttpOnly,SameSite=Lax(Securewhen enabled); API clients may still useAuthorization: Bearer. - Why: tokens never appear in URLs or JS-readable storage, and
SameSite=Laxplus a strictOrigin/Referercheck on cookie-authenticated mutations blocks basic CSRF. - Cost: cookie-based auth needs TLS and correct
COOKIE_SECURE; there is no signed-cookie layer, so the gateway trusts the token hash comparison for validation.
Security and RBAC
The gateway runs with a namespace-scoped ServiceAccount (manifests/50-gateway.yaml):
| API group | Resource | Verbs | Why |
|---|---|---|---|
extensions.agents.x-k8s.io |
sandboxclaims |
get, list, create, delete |
signup, state, account deletion |
agents.x-k8s.io |
sandboxes |
get, list, patch |
resolve DNS/pod, wake/suspend |
"" (core) |
pods |
get, list |
resolve the pod behind a sandbox |
"" (core) |
pods/log |
get |
launch-token handshake |
Notes and limits:
- Pod logs are sensitive. They contain the DSH launch token and possibly model output. The permission is scoped to one namespace, but anyone who can read gateway memory or logs can impersonate users. Prefer the upstream token API when available.
- No cluster-wide access, no secret reads. The gateway does not read
dsh-provider-keys. - Browser-facing hardening:
HttpOnly/SameSite=Lax/optionalSecurecookies, timing-safe SHA-256 token comparison, strict same-origin check on cookie-auth mutations, request-body limit (MAX_BODY_MB), hop-by-hop header stripping, upstreamSet-Cookiedropped, DSHLocationheaders rewritten under/u/<user>/. - Host allow-list: DSH rejects unknown
Hostheaders. The gateway forwards the browser'sHost, so every public hostname must be inDSH_TRUSTED_HOSTS;localhost/127.0.0.1are always trusted. - TLS is external. The gateway serves plain HTTP; terminate TLS at the Ingress and set
COOKIE_SECURE=true. Without TLS, session cookies are replayable on the network. - Tenant isolation is pod + PVC separation; all tenants share one namespace, one DSH binary,
and one
DEEPSEEK_API_KEY. Add NetworkPolicies and per-tenant credentials before calling it multi-tenant-grade. - No gateway rate limiting. Signup can create claims until the cluster or warm pool is exhausted; put limits at the ingress for real deployments.
Failure modes
| Failure | Symptom | Behavior / mitigation |
|---|---|---|
| DSH log line changed or rotated away | Proxy returns 503 (missing launch token) |
Fix the parser or restart the pod so the token line is re-emitted |
Probe on / |
Pod CrashLoopBackOff, 401 in probe logs |
Use /favicon.svg for readiness/liveness (shipped templates do) |
| Warm pool exhausted | JSON signup returns 202 (state Waking); form signup is slow |
Increase replicas in the warm pool |
| Gateway restart | Idle sandboxes stop suspending; handshake cache lost | Rebuilt lazily on next request; consider a shared store for production |
| DSH auth cookie expired mid-session | Proxy 401 once, then recovers |
Gateway refreshes the handshake once |
| Upstream pod name changed after resume | Cached cookie keyed by old pod UID is useless | Cache is invalidated on suspend; next request re-handshakes |
| Two gateway replicas | Double suspend/wake races | Keep replicas: 1 until state is externalized |
Upstream feature request: remove log scraping
DSH should expose the launch token as a first-class, machine-readable interface so platforms do
not need pods/log access. Proposed shapes (any one suffices):
- Token file:
dsh web --token-file /run/dsh/tokenwrites the current launch token (mode0600) and rewrites it on rotation. - Environment input: accept
DSH_LAUNCH_TOKEN(platform-generated) so the token never has to be discovered. - Loopback/trusted-host endpoint:
GET /api/auth/launch-tokenthat only answers on the pod's loopback or a trusted host and returns the token plus expiry. - Token in a well-known file under
DSH_HOMEwith the same semantics as (1).
Why this matters: log scraping is brittle (rotation, restart, format changes), requires a broad
pods/log permission that also exposes application output, and can leak tokens into log
pipelines. Until an upstream API exists, the gateway's parser, DSH_LOG_TAIL_LINES, and the
single-retry refresh are the supported workaround.
Evolution path
- Replace log scraping with the upstream token API (above), deleting the
pods/logpermission. - Move idle clocks, in-flight tracking, and handshake cache to a shared store; then scale the gateway horizontally (sticky routing not required if state is shared).
- Add per-tenant API keys or an egress proxy so a single key is not shared by all sandboxes.
- Add NetworkPolicies (gateway → sandboxes only), TLS everywhere, rate limits, and audit logging at the ingress.
- If DSH grows absolute URLs or per-user cookies that cannot be rewritten, switch to per-user subdomains with wildcard DNS/TLS.